Mark the definition with the new Document attribute as excluded #970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR updates the bundle to support the new Attribute classes introduced in doctrine/mongodb-odm 2.16 while maintaining backward compatibility with the existing Annotations classes. The changes ensure that document classes marked with either the old annotation-based or new attribute-based mapping are properly excluded from the Symfony container.
Key Changes:
- Added support for the new
Attributenamespace classes alongside deprecatedAnnotationsclasses - Refactored autoconfiguration registration to use a loop with conditional class existence checks
- Updated tests to verify both annotation and attribute variants are excluded from the container
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/DependencyInjection/DoctrineMongoDBExtension.php | Refactored autoconfiguration to support both Annotations and Attribute classes with conditional registration |
| tests/DependencyInjection/DoctrineMongoDBExtensionTest.php | Extended test coverage to include new Attribute classes and added conditional test skipping for non-existent classes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
GromNaN
force-pushed
the
attribute-annotations
branch
from
8f5c6b2 to
1d1c5ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure compatibility with doctrine/mongodb-odm#2933 when the new attribute classes are used.