Fix reporting of deprecations in tests#479
Merged
greg0ire merged 1 commit intodoctrine:2.3.xfrom Oct 23, 2025
Merged
Conversation
Because the de-duplication of deprecation notices was disabled by default, not all actual deprecations were reported after doctrine#473.
mpdude
force-pushed
the
fix-test-deprecation-reporting
branch
from
a8ede3e to
704ff97
Compare
Contributor
Author
|
@greg0ire May I ask for your review? I cannot use the GH review request feature here. |
3 tasks
greg0ire
approved these changes
Oct 22, 2025
Contributor
Author
|
It would be nice if we could merge this as-is, so that #472 can proceed. Once doctrine/deprecations#94 is merged and released, we can still improve here. |
SenseException
approved these changes
Oct 22, 2025
Member
|
Thanks @mpdude ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because the de-duplication of deprecation notices was enabled by default, not all actual deprecations were reported after #473.