Skip adding dependency if already added#607
Open
adamwillcock wants to merge 7 commits intodoctrine:2.2.xfrom
Open
Skip adding dependency if already added#607adamwillcock wants to merge 7 commits intodoctrine:2.2.xfrom
adamwillcock wants to merge 7 commits intodoctrine:2.2.xfrom
Conversation
…fixtures which may have dependencies.
Member
|
Please add tests. Also, |
Added tests to ensure that fixture dependencies are not instantiated if they have already been added to the Loader.
This fixes a bug where a fixture dependency with constructor arguments would throw an exception when being added
Added tests to ensure that fixture dependencies are not instantiated if they have already been added to the Loader.
Updated tests to fix linting issues with return types and spacing
Member
|
It seems there are CI jobs failing. Please take a look at this guide for more on how to handle those. |
Updated tests to fix linting issues with annotations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip adding dependency if already added, avoids issues instantiating fixtures which may have dependencies.