Skip to content

Comments

Remove calls to setAccessible#612

Merged
greg0ire merged 1 commit intodoctrine:2.2.xfrom
renanrodrigo:remove-deprecated-set-accessible
Feb 16, 2026
Merged

Remove calls to setAccessible#612
greg0ire merged 1 commit intodoctrine:2.2.xfrom
renanrodrigo:remove-deprecated-set-accessible

Conversation

@renanrodrigo
Copy link
Contributor

The method is a noop since PHP 8.1 and was deprecated in PHP 8.5.

Fixes: #611

@renanrodrigo renanrodrigo force-pushed the remove-deprecated-set-accessible branch from 80688a6 to 3139252 Compare February 16, 2026 19:55
@greg0ire
Copy link
Member

greg0ire commented Feb 16, 2026

Ah we need to update PHPUnit because of the CVE

EDIT: #613

@greg0ire greg0ire closed this Feb 16, 2026
@greg0ire greg0ire reopened this Feb 16, 2026
@greg0ire
Copy link
Member

Triggering a new build

@greg0ire
Copy link
Member

It seems there are CI jobs failing. Please take a look at this guide for more on how to handle those. Most notably, you need to run vendor/bin/phpcbf

The method is a noop since PHP 8.1 and was deprecated in PHP 8.5.

Fixes: doctrine#611
@greg0ire greg0ire force-pushed the remove-deprecated-set-accessible branch from 3139252 to b5c9455 Compare February 16, 2026 20:18
@greg0ire
Copy link
Member

Did it for you.

@greg0ire greg0ire added this to the 2.2.1 milestone Feb 16, 2026
@greg0ire greg0ire merged commit f6bb35f into doctrine:2.2.x Feb 16, 2026
10 checks passed
@greg0ire
Copy link
Member

Thanks @renanrodrigo !

@renanrodrigo renanrodrigo deleted the remove-deprecated-set-accessible branch February 16, 2026 22:25
@renanrodrigo
Copy link
Contributor Author

Hey hello, thanks for handling the CI runs for me :D
And sorry didn't read all contrib docs :|

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ReflectionMethod::setAccessible is deprecated in php 8.5

2 participants