Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/Schema/AbstractSchemaManager.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
use Doctrine\DBAL\Schema\Exception\TableDoesNotExist;
use Doctrine\DBAL\Schema\Name\Parsers;
use Doctrine\DBAL\Types\Exception\TypesException;
use Doctrine\DBAL\Types\Exception\UnknownColumnType;
use Doctrine\Deprecations\Deprecation;
use Throwable;

Expand Down Expand Up @@ -812,7 +813,15 @@ protected function _getPortableTableColumnList(string $table, string $database,
{
$list = [];
foreach ($rows as $row) {
$column = $this->_getPortableTableColumnDefinition($row);
try {
$column = $this->_getPortableTableColumnDefinition($row);
} catch (UnknownColumnType $unknownTypeException) {
throw UnknownColumnType::newWithContext(
$unknownTypeException->getRequestedType(),
$table,
$unknownTypeException,
);
}

$name = strtolower($column->getQuotedName($this->platform));
$list[$name] = $column;
Expand Down
36 changes: 34 additions & 2 deletions src/Types/Exception/UnknownColumnType.php
Original file line number Diff line number Diff line change
Expand Up @@ -5,24 +5,56 @@
namespace Doctrine\DBAL\Types\Exception;

use Exception;
use Throwable;

use function sprintf;

final class UnknownColumnType extends Exception implements TypesException
{
private string $requestedType;

public function getRequestedType(): string
{
return $this->requestedType;
}

public static function new(string $name): self
{
return new self(
$object = new self(sprintf(
'Unknown column type "%s" requested. Any Doctrine type that you use has '
. 'to be registered with \Doctrine\DBAL\Types\Type::addType(). You can get a list of all the '
. 'known types with \Doctrine\DBAL\Types\Type::getTypesMap(). If this error occurs during database '
. 'introspection then you might have forgotten to register all database types for a Doctrine Type. '
. 'Use AbstractPlatform#registerDoctrineTypeMapping() or have your custom types implement '
. 'Type#getMappedDatabaseTypes(). If the type name is empty you might '
. 'have a problem with the cache or forgot some mapping information.',
$name,
));

$object->requestedType = $name;

return $object;
}

public static function newWithContext(string $name, string $tableName, ?Throwable $previous): self
{
$object = new self(
sprintf(
'Unknown column type "%s" requested. Any Doctrine type that you use has '
'Unknown column type "%s" requested for table "%s". Any Doctrine type that you use has '
. 'to be registered with \Doctrine\DBAL\Types\Type::addType(). You can get a list of all the '
. 'known types with \Doctrine\DBAL\Types\Type::getTypesMap(). If this error occurs during database '
. 'introspection then you might have forgotten to register all database types for a Doctrine Type. '
. 'Use AbstractPlatform#registerDoctrineTypeMapping() or have your custom types implement '
. 'Type#getMappedDatabaseTypes(). If the type name is empty you might '
. 'have a problem with the cache or forgot some mapping information.',
$name,
$tableName,
),
previous: $previous,
);

$object->requestedType = $name;

return $object;
}
}
14 changes: 14 additions & 0 deletions tests/Schema/ColumnEditorTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
use Doctrine\DBAL\Schema\Column;
use Doctrine\DBAL\Schema\Exception\InvalidColumnDefinition;
use Doctrine\DBAL\Schema\Name\UnqualifiedName;
use Doctrine\DBAL\Types\Exception\UnknownColumnType;
use Doctrine\DBAL\Types\IntegerType;
use Doctrine\DBAL\Types\Type;
use Doctrine\DBAL\Types\Types;
Expand Down Expand Up @@ -78,4 +79,17 @@ public function testTypeNotSet(): void

$editor->create();
}

public function testInvalidType(): void
{
$this->expectException(UnknownColumnType::class);
$this->expectExceptionMessage('Unknown column type "unknown_type"');

Column::editor()
->setUnquotedName('column_char')
->setTypeName('unknown_type')
->setFixed(true)
->setLength(2)
->create();
}
}
33 changes: 33 additions & 0 deletions tests/Types/Exception/UnknownColumnTypeTest.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
<?php

declare(strict_types=1);

namespace Doctrine\DBAL\Tests\Types\Exception;

use Doctrine\DBAL\Types\Exception\UnknownColumnType;
use PHPUnit\Framework\TestCase;

class UnknownColumnTypeTest extends TestCase
{
public function testNew(): void
{
$exception = UnknownColumnType::new('custom_type');

self::assertSame('custom_type', $exception->getRequestedType());
self::assertStringContainsString(
'Unknown column type "custom_type" requested.',
$exception->getMessage(),
);
}

public function testWithContext(): void
{
$exception = UnknownColumnType::newWithContext('custom_type', 'some_table', null);

self::assertSame('custom_type', $exception->getRequestedType());
self::assertStringContainsString(
'Unknown column type "custom_type" requested for table "some_table".',
$exception->getMessage(),
);
}
}