Apply asset filtering to schema name retrieval #7164
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Filters are currently only applied to table and sequence names, but not to schema names.
I discovered the issue when using the
schema_filterparameter in the Doctrine config of a Symfony project:The schema named
schema_name_that_i_want_to_ignoredoes exist in my PostgreSQL database, but I want it to be ignored.However, when I generate Doctrine migrations with the
doctrine:migrations:diffcommand, I realized the schema gets ignored in the automatically generatedupmethod, but not in the automatically generateddownmethod where I constantly get the following call:And it actually comes down to the missing filter call for schema names.
This PR adds the call to filter + adds a test very similar to the existing
testListTablesWithFiltertest.Let me know if you have any questions or suggestion!