Skip to content

Laravel 13.x Compatibility#152

Closed
laravel-shift wants to merge 1 commit intodoctrine:2.1.xfrom
laravel-shift:l13-compatibility
Closed

Laravel 13.x Compatibility#152
laravel-shift wants to merge 1 commit intodoctrine:2.1.xfrom
laravel-shift:l13-compatibility

Conversation

@laravel-shift
Copy link

This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 13.x.

Before merging, you need to:

  • Checkout the l13-compatibility branch
  • Review all comments for additional changes
  • Thoroughly test your package

If you do find an issue, please report it by commenting on this PR to help improve future automation.

@laravel-shift
Copy link
Author

⚠️ The latest version of Laravel has a dependency for phpunit/phpunit of ^12.5. If you would like to also upgrade your tests, you may run the PHPUnit 12 Shift for free.

@laravel-shift
Copy link
Author

ℹ️ Shift did not find any dependencies for Laravel or popular community packages which were incompatible with Laravel 13.

@laravel-shift
Copy link
Author

⚠️ Shift detected GitHub Actions which run jobs using a version matrix. Shift attempted to update your configuration for Laravel 13. However, you should review these changes to ensure the desired combination of versions are built for your package.

@laravel-shift
Copy link
Author

⚗️ Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch.

To do so, temporarily add Shift's fork to the repositories property of your composer.json:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/laravel-shift/instantiator.git"
        }
    ]
}

Then update your dependency constraint to reference this branch:

{
    "require": {
        "doctrine/instantiator": "dev-l13-compatibility",
    }
}

Finally, run: composer update

php-version:
- "8.4"
- "8.5"
php-version: ['8.3', '8.4', '8.4', '8.5', '8.5']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks wrong

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't have enough tests running PHP 8.4 and 8.5... and non-failing 8.3 for some reason. 🤔

@derrabus
Copy link
Member

Hello Laravel, please send a human being. Love, Doctrine. 🧡

@derrabus derrabus closed this Feb 22, 2026
@jasonmccreary
Copy link

@derrabus, this isn't Laravel. This is me from Shift. I am a human.

These are sent to help package authors prepare for the upcoming Laravel 13 release. However, I see this only made workflow changes. I'll get that patched up. I'll also remove Doctrine repos from our automation. Love, Shift.

@derrabus
Copy link
Member

Hello @jasonmccreary, thank you for your response. If we can be of assistance with getting the ecosystem ready for Laravel 13, we're always glad to help. But your bot indeed only made unrelated GHA workflow changes here and on the other Doctrine repos where I closed its PRs. Thank you for your work with Shift and sorry if I have been a little rude with your bot. 🙂

@jasonmccreary
Copy link

jasonmccreary commented Feb 22, 2026

Yes, as noted, this was patched. This automation only runs once a year. This is the first year Laravel didn't have any major bumps in their core dependencies. As such, packages which don't directly depend on Laravel (or illuminate), may not require changes to composer.json (potentially only changing workflows).

I run these in batches so I can review and incorporate feedback. Just so happened this package was in the first batch and received an unnecessary PR.

Again, all patched up (including those duplicated versions). So these hopefully won't be an issue moving forward. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants