Conversation
|
|
|
ℹ️ Shift did not find any dependencies for Laravel or popular community packages which were incompatible with Laravel 13. |
|
|
|
⚗️ Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch. To do so, temporarily add Shift's fork to the {
"repositories": [
{
"type": "vcs",
"url": "https://github.com/laravel-shift/instantiator.git"
}
]
}Then update your dependency constraint to reference this branch: {
"require": {
"doctrine/instantiator": "dev-l13-compatibility",
}
}Finally, run: |
| php-version: | ||
| - "8.4" | ||
| - "8.5" | ||
| php-version: ['8.3', '8.4', '8.4', '8.5', '8.5'] |
There was a problem hiding this comment.
You can't have enough tests running PHP 8.4 and 8.5... and non-failing 8.3 for some reason. 🤔
|
Hello Laravel, please send a human being. Love, Doctrine. 🧡 |
|
Hello @jasonmccreary, thank you for your response. If we can be of assistance with getting the ecosystem ready for Laravel 13, we're always glad to help. But your bot indeed only made unrelated GHA workflow changes here and on the other Doctrine repos where I closed its PRs. Thank you for your work with Shift and sorry if I have been a little rude with your bot. 🙂 |
|
Yes, as noted, this was patched. This automation only runs once a year. This is the first year Laravel didn't have any major bumps in their core dependencies. As such, packages which don't directly depend on Laravel (or I run these in batches so I can review and incorporate feedback. Just so happened this package was in the first batch and received an unnecessary PR. Again, all patched up (including those duplicated versions). So these hopefully won't be an issue moving forward. 👍 |
This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 13.x.
Before merging, you need to:
l13-compatibilitybranchIf you do find an issue, please report it by commenting on this PR to help improve future automation.