Always update migrated versions#1094
Open
kick-the-bucket wants to merge 1 commit intodoctrine:3.0.xfrom
Open
Conversation
Member
|
Hmm... I find this very risky (even if probably it will help local development...). I do not understand in which situations version names are not in sync? from my understanding, this happens only for a short period while migrating from 2.x to 3.x, isnt? |
Author
|
Situation:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When migrating from v2 to v3 in a big project (with different migration classes in different branches) metadata sync becomes very cumbersome when you already have executed migrations from other branches than you are currently on, since the version names are only migrates once along with the table structure. At the moment the workaround we use is dropping the
execution_timecolumn before runningdoctrine:migrations:migrate, to ensure the names are always updated when you're in a branch with already executed, but not yet synced version names.This change will make the names always update, no matter if there are structural changes to the table needed or not.
If this is not preferred - I could add a new flag to enable this behavior only when needed.