Introduce addDeferredSql method in migration class#1478
Open
srsbiz wants to merge 1 commit intodoctrine:4.0.xfrom
Open
Introduce addDeferredSql method in migration class#1478srsbiz wants to merge 1 commit intodoctrine:4.0.xfrom
srsbiz wants to merge 1 commit intodoctrine:4.0.xfrom
Conversation
srsbiz
force-pushed
the
add-deferred-sql
branch
from
4d308f8 to
1f344eb
Compare
srsbiz
changed the title
srsbiz
force-pushed
the
add-deferred-sql
branch
from
1f344eb to
6f6ead1
Compare
This will allow to add queries that needs to be executed after changes made to schema object.
srsbiz
force-pushed
the
add-deferred-sql
branch
from
6f6ead1 to
2667666
Compare
Contributor
Author
|
Failing check is caused by #1456 |
Contributor
Author
|
@greg0ire @stof @SenseException @derrabus Can I have any comment on this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This will allow to add queries that needs to be executed after changes made to schema object.
Reason for this change
When people need to write data in newly created table / added column, they probably resorts to calling
$this->connection->executeStatementinpostUp, and this may be wrong in at least two scenarios:--dry-runoption,executeStatementis always called, since migration does not know about dry-run mode-vvor--write-sqloptions, sinceexecuteStatementdoes not log queries likeaddSql.