Handle schema names in table metadata#1567
Open
greg0ire wants to merge 1 commit intodoctrine:3.9.xfrom
Open
Conversation
In a previous commit, I switched from introspectTable(), which handles this with a single argument to introspectTableByUnquotedName(), which handles it with two.
Member
|
It looks like there's no test that covers table names with a dot. Maybe you can cover your new code path with a test like |
Member
Author
|
@SenseException that test relies on SQLite, which does not support namespaces. |
|
I can confirm that this PR fixes #1566 Thank you! |
Member
|
@greg0ire It introduces a new code path with a new if-block, that I, AFAIK, don't see covered by a test. Please let me know if there's one that covers the new path elsewhere that I missed. |
Member
Author
|
I don't think it is currently covered because it is about schemas, and we only have SQLite available in this test suite I think, and it does not support schemas, or rather, the corresponding DBAL platform doesn't. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1566
In a previous commit, I switched from
introspectTable(), which handles this with a single argument tointrospectTableByUnquotedName(), which handles it with 2 arguments.I could not find a way to test this since we use SQLite and that the corresponding DBAL platform does not support schemas.