Closed
Conversation
GromNaN
reviewed
Jan 10, 2025
Member
GromNaN
left a comment
GromNaN
left a comment
There was a problem hiding this comment.
Sounds good to me, once the type issue is solved.
| #[ODM\Document(collection: 'documents')] | ||
| #[ODM\InheritanceType('SINGLE_COLLECTION')] | ||
| #[ODM\DiscriminatorField('type')] | ||
| #[ODM\DiscriminatorMap([0 => GH2158FirstType::class, 1 => GH2158SecondType::class])] |
Member
There was a problem hiding this comment.
Using int as key is not permitted by the @param annotation, this rule is not enforced in the code.
I propose to relax the type.
- /** @param array<string, class-string> $value */
+ /** @param array<class-string> $value */ 
Member
|
Also, this is a bug fix. Could you reset the PR on 2.9.x. This will also ensure that the tests pass with #2714 |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix discriminator value 0