Skip empty $match from pipeline builder#2740
Merged
GromNaN merged 2 commits intodoctrine:2.11.xfrom Mar 6, 2025
Merged
Conversation
GromNaN
commented
Mar 3, 2025
Member
Author
GromNaN
left a comment
GromNaN
left a comment
There was a problem hiding this comment.
We can do the same for $addFields and $set.
But also for $unsetFields and $project. This stages doesn't accept empty lists, so this can be an improvement.
| * @phpstan-return StageExpression | ||
| */ | ||
| abstract public function getExpression(): array; | ||
| abstract public function getExpression(): ?array; |
Member
Author
There was a problem hiding this comment.
Classes extending this can still restrict the return type.
jmikola
reviewed
Mar 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Don't send an unnecessary stage to the server.
Might be considered as a breaking change is someone manipulate the generated pipeline.