Fix $geoNear stage with empty query#2743
Merged
GromNaN merged 1 commit intodoctrine:2.11.xfrom Mar 6, 2025
Merged
Conversation
GromNaN
force-pushed
the
geonear-empty-query
branch
2 times, most recently
from
90af756 to
66996ef
Compare
GromNaN
force-pushed
the
geonear-empty-query
branch
from
66996ef to
24e0f5b
Compare
jmikola
approved these changes
Mar 6, 2025
Member
jmikola
left a comment
jmikola
left a comment
There was a problem hiding this comment.
Decide if the test case should be renamed. Everything else LGTM.
| use Doctrine\ODM\MongoDB\Tests\BaseTestCase; | ||
| use Documents\Place; | ||
|
|
||
| class GeoTest extends BaseTestCase |
Member
There was a problem hiding this comment.
Should this be titled GeoNearTest, or would you intend for other geospatial operators to get added to this down the line?
Member
Author
There was a problem hiding this comment.
My idea is that we can add other tests for other operators using the fixtures already defined.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
$geoNearstage propertyqueryrequires a document. When nothing is set, an empty array is currently sent; which is invalid.