-
-
Notifications
You must be signed in to change notification settings - Fork 516
[3.x] Remove support for Doctrine Annotations #2931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
IonBazan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- We should also update the
docs/annotations-reference.mdaccordingly. - PHP attributes are still in
Annotationsnamespace - this is something we won't be able to change easily and might be confusing to new users as docs and other places still use annotations/attributes interchangeably.
What about using the Annotation namespace as an alias of the Attribute namespace, like Symfony did? And deprecating the annotation namespace later? |
|
@mickverm this is possible, even without aliasing - using inheritance but we would need to keep a copy of all Attribute classes. That should target 2.16.x or 2.17.x then once we decide whether we should pursue that option for v3. |
|
We have to check if that's possible with attributes, because they are read without actually loading the classes. |
|
See #2933 |
Summary
@Annotationfrom attribute classes