[3.x] Added asymetric visibility to ClassMetadata fields #2938
+204
−189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
IonBazan
reviewed
Nov 29, 2025
GromNaN
reviewed
Nov 29, 2025
GromNaN
reviewed
Nov 29, 2025
| * The name of the mongo database the document is mapped to. | ||
| */ | ||
| public $db; | ||
| public private(set) ?string $db = null; |
Member
There was a problem hiding this comment.
public is the default. I think our CS should be to not set it?
Suggested change
| public private(set) ?string $db = null; | |
| private(set) ?string $db = null; |
@doctrine/maintainers WDYT?
krzysztof-ciszewski
force-pushed
the
read-only-class-metadata-fields
branch
from
3d29ae9 to
274a709
Compare
…y-class-metadata-fields
krzysztof-ciszewski
force-pushed
the
read-only-class-metadata-fields
branch
from
b1109c0 to
88dc22e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Made public ClassMetadata have private setters. Will cause conflicts with #2935