Fix ClassMetadata type for SearchIndexMapping#2988
Merged
paulinevos merged 1 commit intodoctrine:2.16.xfrom Jan 29, 2026
Merged
Fix ClassMetadata type for SearchIndexMapping#2988paulinevos merged 1 commit intodoctrine:2.16.xfrom
SearchIndexMapping#2988paulinevos merged 1 commit intodoctrine:2.16.xfrom
Conversation
A `SearchIndexMapping` can have either `SearchIndexDefinition` or `VectorSearchIndexDefinition` for `definition`. Currently it is missing the latter.
GromNaN
approved these changes
Jan 29, 2026
Member
GromNaN
left a comment
GromNaN
left a comment
There was a problem hiding this comment.
Thanks.
We could add a test that uses this method so that PHPStan would validate the input array. But that's not a requirement.
paulinevos
added a commit
that referenced
this pull request
Jan 29, 2026
A `SearchIndexMapping` can have either `SearchIndexDefinition` or `VectorSearchIndexDefinition` for `definition`. Currently it is missing the latter. Co-authored-by: Pauline Vos <pvos88@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A
SearchIndexMappingcan have eitherSearchIndexDefinitionorVectorSearchIndexDefinitionfordefinition. Currently it is missing the latter.