Skip to content

Conversation

@xabbuh
Copy link
Member

@xabbuh xabbuh commented Sep 29, 2025

No description provided.

@xabbuh
Copy link
Member Author

xabbuh commented Sep 29, 2025

I guess we need doctrine/persistence#437 first

@xabbuh xabbuh force-pushed the php-8.5-job branch 2 times, most recently from dc5a57f to 555f7ca Compare September 29, 2025 06:58
@xabbuh
Copy link
Member Author

xabbuh commented Sep 29, 2025

for some of the __sleep()/__wakeup() related deprecations an update of symfony/string would be required but we only introduced the new methods in the upcoming 7.4 release

https://wiki.php.net/rfc/soft-deprecate-sleep-wakeup which looks to be accepted in a few days looks promising here and the merge of php/php-src#19966 will then unlock the ability to actually get the job green here

@xabbuh
Copy link
Member Author

xabbuh commented Oct 7, 2025

We don't need to worry about the __sleep()/__wakeup() deprecations for now as the aforementioned RFC passed. However, before being ready for PHP 8.5 in ORM we also need DBAL to be compatible (see doctrine/dbal#7173 and doctrine/dbal#7174).

@derrabus derrabus closed this Oct 9, 2025
@derrabus derrabus reopened this Oct 9, 2025
@derrabus derrabus added the CI label Oct 9, 2025
@derrabus derrabus added this to the 2.20.7 milestone Oct 9, 2025
@derrabus derrabus merged commit 3b7de17 into doctrine:2.20.x Oct 9, 2025
155 of 170 checks passed
@xabbuh xabbuh deleted the php-8.5-job branch October 9, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants