Skip to content

Update dodona-tested dockerfile to match pr #609 #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jorg-vr wants to merge 1 commit into from
Closed

Update dodona-tested dockerfile to match pr #609 #397

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions dodona-tested.dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,19 +13,18 @@
# Set up the environment

# Kotlin
ENV SDKMAN_DIR /usr/local/sdkman

Check warning on line 16 in dodona-tested.dockerfile

View workflow job for this annotation

GitHub Actions / tested

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
ENV PATH $SDKMAN_DIR/candidates/kotlin/current/bin:$PATH

Check warning on line 17 in dodona-tested.dockerfile

View workflow job for this annotation

GitHub Actions / tested

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
ENV PATH $SDKMAN_DIR/candidates/java/current/bin:$PATH

Check warning on line 18 in dodona-tested.dockerfile

View workflow job for this annotation

GitHub Actions / tested

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
# Haskell
ENV HASKELL_DIR /usr/local/ghcupdir

Check warning on line 20 in dodona-tested.dockerfile

View workflow job for this annotation

GitHub Actions / tested

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
ENV PATH $HASKELL_DIR/ghc/bin:$PATH

Check warning on line 21 in dodona-tested.dockerfile

View workflow job for this annotation

GitHub Actions / tested

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
ENV PATH $HASKELL_DIR/cabal:$PATH

Check warning on line 22 in dodona-tested.dockerfile

View workflow job for this annotation

GitHub Actions / tested

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
# Node
ENV NODE_PATH /usr/lib/node_modules

Check warning on line 24 in dodona-tested.dockerfile

View workflow job for this annotation

GitHub Actions / tested

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

# Install dependencies
# hadolint ignore=DL3013,DL3016
RUN <<EOF

Check warning on line 27 in dodona-tested.dockerfile

View workflow job for this annotation

GitHub Actions / tested 

Pin versions in npm. Instead of `npm install <package>` use `npm install <package>@<version>`
# Update apt-get
apt-get update

Expand Down Expand Up @@ -109,16 +108,9 @@
# Java specific dependencies
apt-get install -y --no-install-recommends checkstyle

# Exercise dependencies
pip install --no-cache-dir --upgrade \
numpy==2.3.5

# Clean up caches
# Clean up apt caches
apt-get clean
rm -rf /var/lib/apt/lists/*
rm -rf /root/.cache
rm -rf /root/.npm
rm -rf /usr/local/sdkman/tmp

# Setup permissions and user
chmod 711 /mnt
Expand Down
Loading