Don't clear files in the state on execution start#1000
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR changes frontend execution reset behavior so that the in-memory io.files list is no longer cleared at the start of a run, and adds a regression test to ensure files remain visible while the next run is waiting for user input.
Changes:
- Stop clearing
InputOutput.filesduringreset()(triggered onBackendEventType.Start). - Add a test covering file persistence across runs while the runner is awaiting input.
- Extend test helpers usage to wait specifically for the awaiting-input state.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/frontend/state/InputOutput.ts |
Keeps files state across Start resets by removing this.files = [] from reset(). |
test/__tests__/state/Files.test.ts |
Adds a test validating that files from a previous run are still present while the next run is awaiting input. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
chvp
force-pushed
the
fix/dont-clear-files-on-start
branch
from
e37d49c to
81ea8ba
Compare
TomNaessens
approved these changes
Apr 14, 2026
bmesuere
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
But do clear them when the list of files becomes empty.