Fix infinite hang during lint when code contains some imports#996
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses an infinite hang during Python linting (PyLint/astroid in the Pyodide worker) when user code contains import re.
Changes:
- Add Vitest coverage for executing Python code that imports
re. - Add a linting regression test to ensure
lintSource()completes forimport re. - Introduce an astroid monkeypatch in the Python worker linting layer to short-circuit module loading for
reand related modules.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| test/tests/state/Runner.test.ts | Adds runtime and lint regression tests around import re. |
| src/backend/workers/python/papyros/linting.py | Monkeypatches astroid module loading to avoid the hang when linting code that imports re. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Closed
chvp
changed the title
Member
Author
|
I expanded the scope of this PR to disable the loading of all modules by astroid, since we were having issues with pandas dataframes as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason, the astroid version we use hangs indefinitely when linting
import reor usage of pandas dataframes. This is because it goes into the modules and gets into some infinite recursion there.This is a band-aid fix since updating astroid would involve updating pylint, and we use some APIs that were removed in newer versions. I will create an issue for updating pylint separately (which will mention to try removing this band-aid).
Fixes #950.