Correctly generate multiple CLI arguments for Haskell#580
Merged
jorg-vr merged 2 commits intododona-edu:masterfrom Feb 26, 2025
Merged
Correctly generate multiple CLI arguments for Haskell#580jorg-vr merged 2 commits intododona-edu:masterfrom
jorg-vr merged 2 commits intododona-edu:masterfrom
Conversation
niknetniko
requested changes
Feb 21, 2025
Member
niknetniko
left a comment
There was a problem hiding this comment.
You'll need to run the formatter, but otherwise changes look good to me.
niknetniko
approved these changes
Feb 24, 2025
Contributor
|
Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a bug with the Haskell judge where the list that contains the command line arguments was not correctly compiled into Haskell, due to a missing comma in the generated output.
Example Testcase
The following line is responsible for converting it to Haskell:
universal-judge/tested/languages/haskell/generators.py
Line 244 in 3b65304
However, this generates something like this:
This causes an error like this:
In Haskell, arrays are comma separated. This PR adds the commas, as well as a test-case for it.