fix: upgrade react-native-worklets to 0.5.2 to fix web crash #875
+18
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #864 The documentation website examples were crashing with error: "WorkletsError: createSerializableObject should never be called in JSWorklets" This was caused by a bug in react-native-worklets 0.5.1 where the PlatformChecker was not properly initialized in lazy import environments like web. The fix was released in version 0.5.2. Changes: - Upgrade react-native-worklets from 0.5.1 to 0.5.2 in root package.json - Upgrade react-native-worklets from 0.5.1 to 0.5.2 in example/app
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dosubot
bot
added
the
size:S
🦋 Changeset detectedLatest commit: 317e073 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Related Documentation Checked 1 published document(s) in 1 knowledge base(s). No updates required. How did I do? Any feedback? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #875 +/- ##
=======================================
Coverage 81.90% 81.90%
=======================================
Files 35 35
Lines 1006 1006
Branches 339 337 -2
=======================================
Hits 824 824
Misses 81 81
Partials 101 101 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
react-native-workletsfrom 0.5.1 to 0.5.2Problem
The web examples were crashing with the error:
This was caused by a bug in
react-native-worklets0.5.1 whereglobalThis.__RUNTIME_KINDwas accessed before initialization in lazy import environments (like web).Solution
Upgrade to
react-native-worklets0.5.2 which contains the fix from software-mansion/react-native-reanimated#8300.Test plan
yarn weband confirmed the carousel worksFixes #864