This repository was archived by the owner on Nov 11, 2024. It is now read-only.
feat: add model upgradeability check (n-03) #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glihm
commented
Nov 5, 2024
Comment on lines
+605
to
+608
| self | ||
| .assert_resource_upgradability( | ||
| @namespace, @model_name, prev_address, new_contract_address | ||
| ); |
Contributor
Author
There was a problem hiding this comment.
This is the most notable change, for model and event.
Comment on lines
+1066
to
+1087
| fn assert_resource_upgradability( | ||
| self: @ContractState, | ||
| namespace: @ByteArray, | ||
| name: @ByteArray, | ||
| prev_address: ContractAddress, | ||
| new_address: ContractAddress | ||
| ) { | ||
| let resource = IStoredResourceDispatcher { contract_address: prev_address }; | ||
| let old_layout = resource.layout(); | ||
| let old_schema = resource.schema(); | ||
|
|
||
| let new_resource = IStoredResourceDispatcher { contract_address: new_address }; | ||
| let new_layout = new_resource.layout(); | ||
| let new_schema = new_resource.schema(); | ||
|
|
||
| if !new_layout.is_same_type_of(@old_layout) { | ||
| panic_with_byte_array(@errors::invalid_resource_layout_upgrade(namespace, name)); | ||
| } | ||
|
|
||
| if !new_schema.is_an_upgrade_of(@old_schema) { | ||
| panic_with_byte_array(@errors::invalid_resource_schema_upgrade(namespace, name)); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
New function without side effect only to check if a model/event is a good candidate for upgradeability.
glihm
changed the title
…hence can't be flatten at compile time
* backport 1 * fix: fix contracts path
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.