ci: remove missing bench

[kariy]

closes #129

[claude]

Claude finished @kariy's task —— View job

---

Pull Request Review

Review Checklist

• Read and analyze the workflow file changes
• Review for code quality and best practices
• Check for potential bugs or issues
• Consider performance implications
• Evaluate security concerns
• Assess impact on test coverage
• Provide comprehensive review feedback

Summary

This PR fixes a broken CI workflow by replacing a reference to a non-existent benchmark with an existing one.

Changes Analysis

The PR makes two changes to .github/workflows/bench.yml:

1. Line 24: Removes trailing whitespace (minor formatting fix)
2. Line 30: Replaces --bench concurrent with --bench commit

Review Findings

✅ Code Quality and Best Practices

• The change correctly fixes a broken reference to a non-existent benchmark
• The formatting improvement (removing trailing whitespace) is good practice
• The workflow continues to follow GitHub Actions best practices

✅ Potential Bugs or Issues

• Issue Fixed: The concurrent benchmark doesn't exist in the codebase, which would cause the workflow to fail
• Resolution: Replacing it with commit benchmark (which exists at crates/core/benches/commit.rs) resolves the issue
• No new bugs introduced

✅ Performance Considerations

• The commit benchmark tests both serial and parallel block commit operations, which provides good performance coverage
• No negative performance impact from this change
• The workflow will now successfully complete, providing actual benchmark data

✅ Security Concerns

• No security issues identified
• The workflow maintains appropriate permissions (deployments: write, contents: write)
• No sensitive data exposure

⚠️ Test Coverage

• While this fixes the CI, it appears we've lost coverage for concurrent operations benchmarking
• The commit benchmark does include parallel commit tests, which provides some concurrency testing
• Consider creating a dedicated concurrent benchmark in the future if concurrent operation performance is important

Recommendations

1. Approve this PR - It fixes a broken CI workflow by correcting an invalid benchmark reference
2. Future consideration: If concurrent operation benchmarking was intended, consider creating a proper concurrent benchmark file
3. Documentation: Consider adding a comment in the workflow file listing available benchmarks to prevent similar issues

Verdict

This is a straightforward and necessary fix that resolves a CI failure. The change is minimal, correct, and improves the workflow's reliability.