Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #356 +/- ##
==========================================
+ Coverage 73.32% 74.96% +1.64%
==========================================
Files 209 250 +41
Lines 23132 30234 +7102
==========================================
+ Hits 16961 22666 +5705
- Misses 6171 7568 +1397 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
chudkowsky
pushed a commit
that referenced
this pull request
Nov 18, 2025
the `abi` field in rpc format for the contract class can be an arbitrary string. this is what the jsonrps [spec] says:
```json
"abi": {
"title": "ABI",
"type": "string",
"description": "The class ABI, as supplied by the user declaring the class"
}
```
currently, if the rpc abi string can't be converted into the `ContractAbi` type, it will fail during the deserialization phase. the abi string must be preserved as well because it's part of the class hash computation. so we need to preserve the raw string even if it's just some random string.
Starknet class with arbitrary abi string: `0x22b7d06d355ddb1c485ec9cc09b488e77e63318db8833104aed56d598416417` where the abi string returned by the RPC is literally this `"Declared from starknet-rs test case. Timestamp (ms): 1709974545243"`.
superseded #353 .
this change also include a database version bump ( 7 -> 8 ) because of the change made to the value type of the `Classes` table i.e., the `katana_primitives::class::ContractClass` enum.
[spec]:
https://github.com/starkware-libs/starknet-specs/blob/c2e93098b9c2ca0423b7f4d15b201f52f22d8c36/api/starknet_api_openrpc.json#L3215C8-L3219C12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the
abifield in rpc format for the contract class can be an arbitrary string. this is what the jsonrps spec says:currently, if the rpc abi string can't be converted into the
ContractAbitype, it will fail during the deserialization phase. the abi string must be preserved as well because it's part of the class hash computation. so we need to preserve the raw string even if it's just some random string.Starknet class with arbitrary abi string:
0x22b7d06d355ddb1c485ec9cc09b488e77e63318db8833104aed56d598416417where the abi string returned by the RPC is literally this"Declared from starknet-rs test case. Timestamp (ms): 1709974545243".superseded #353 .
this change also include a database version bump ( 7 -> 8 ) because of the change made to the value type of the
Classestable i.e., thekatana_primitives::class::ContractClassenum.