Skip to content

fix(cli): merge explorer options from config file#384

Merged
kariy merged 1 commit intomainfrom
fix/explorer-config
Dec 18, 2025
Merged

fix(cli): merge explorer options from config file#384
kariy merged 1 commit intomainfrom
fix/explorer-config

Conversation

@kariy
Copy link
Member

@kariy kariy commented Dec 18, 2025

The [explorer] section in katana.toml was being ignored because NodeArgsConfig was missing the explorer field and with_config_file() didn't merge it. This adds the missing field and merge logic so that explorer = true in the config file now works the same as the --explorer CLI flag.

🤖 Generated with Claude Code

@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

❌ Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.60%. Comparing base (9bde0ae) to head (dfd4f2b).
⚠️ Report is 217 commits behind head on main.

Files with missing lines Patch % Lines
crates/cli/src/file.rs 0.00% 3 Missing ⚠️
crates/cli/src/args.rs 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #384      +/-   ##
==========================================
+ Coverage   73.32%   73.60%   +0.28%     
==========================================
  Files         209      257      +48     
  Lines       23132    33151   +10019     
==========================================
+ Hits        16961    24402    +7441     
- Misses       6171     8749    +2578     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kariy kariy merged commit 48e9efd into main Dec 18, 2025
9 of 11 checks passed
@kariy kariy deleted the fix/explorer-config branch December 18, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant