-
Notifications
You must be signed in to change notification settings - Fork 11
chore: bump blockifier to v0.16.0-rc.0
#392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
at commit serde broke the private api in serde-rs/serde#2980. solved in |
blockifier to v0.16.0-rc.0
e3bd68b to
e897bbb
Compare
68cbbac to
c0d49bb
Compare
|
starknet-io/types-rs#155 breaks the serialization format for |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #392 +/- ##
==========================================
- Coverage 73.32% 72.74% -0.59%
==========================================
Files 209 248 +39
Lines 23132 29645 +6513
==========================================
+ Hits 16961 21564 +4603
- Misses 6171 8081 +1910 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Related #393, #388, #198, #209, #211, #256, #268.
When running
cargo vendor, we're stuck with this error:The dependencies bump is required because we are removing the
starknetcrate patch:The initial reason for the patch is for this PR xJonathanLEI/starknet-rs#773 but it's no longer needed since #256.
The dependency updates were originally meant to only make the project compile after removing the patch. Given the tight integration with
blockifierand the breaking database format change introduced inv0.16.0-rc.0, this PR is now primarily about updatingblockifier, with patch removal as a side effect.Database Backward Compatibility
TransactionExecutionInfo
blockifierv0.16.0-rc.0 has a breaking change in theTransactionExecutionInfostruct. In order to maintain backward-compatibility, if database can't deserialize theTransactionExecutionInfoit'd simply return nothing instead of failing.This is still temporary for now and may change once we find a better solution that doesn't require dropping old data.
Felt Serialization
The
starknet-types-corecrate has a breaking change inFeltserialization (see starknet-io/types-rs#155). To maintain backward compatibility with existing databases, aFelt32wrapper type is used to ensureFeltvalues are always serialized as 32-byte big-endian arrays when stored in the database.The reason to vendor the Cargo dependencies is to make the Katana binary build hermetic in order to achieve reproducible build process.