Skip to content

Desktop popup fix (fix no value updates for text fields in the sheet)#210

Merged
dokar3 merged 2 commits intomainfrom
desktop-popup-fix
Mar 15, 2026
Merged

Desktop popup fix (fix no value updates for text fields in the sheet)#210
dokar3 merged 2 commits intomainfrom
desktop-popup-fix

Conversation

@dokar3
Copy link
Owner

@dokar3 dokar3 commented Mar 15, 2026

Summary by CodeRabbit

  • Bug Fixes

    • Enhanced focus handling in desktop sheet modal dialogs to improve responsiveness when interacting via keyboard and mouse, providing a more seamless experience when using and dismissing modals
  • Chores

    • Updated sample application build configuration for desktop Compose environments to ensure proper alignment with project structure

@coderabbitai
Copy link

coderabbitai bot commented Mar 15, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 63454589-f016-4d38-b344-a48d28cf4139

📥 Commits

Reviewing files that changed from the base of the PR and between 2c4ca18 and 0421712.

📒 Files selected for processing (2)
  • sample/build.gradle.kts
  • sheets-core/src/desktopMain/kotlin/com/dokar/sheets/Platform.desktop.kt

📝 Walkthrough

Walkthrough

This pull request updates the desktop sample build configuration to reference the "sheets" package instead of "sonner," and enhances the desktop Popup implementation with PopupProperties to enable focus control in the sheet host.

Changes

Cohort / File(s) Summary
Sample Build Configuration
sample/build.gradle.kts
Updated mainClass and packageName from com.dokar.sonner.sample to com.dokar.sheets.sample in the Compose desktop application block.
Desktop Platform Enhancement
sheets-core/src/desktopMain/kotlin/com/dokar/sheets/Platform.desktop.kt
Modified Popup invocation to include PopupProperties(focusable = true), adding import and enhancing focus behavior control.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A bundle of changes, both tidy and small,
The sample now knows its true name after all!
With focus properties, the sheets take the stage,
Desktop companions compose a new page. ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly relates to the main changes: adding PopupProperties(focusable = true) to fix text field value updates in sheet popups on desktop, which is the primary behavioral change in the PR.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch desktop-popup-fix
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can disable sequence diagrams in the walkthrough.

Disable the reviews.sequence_diagrams setting to disable sequence diagrams in the walkthrough.

@dokar3 dokar3 merged commit 49edc53 into main Mar 15, 2026
2 checks passed
@dokar3 dokar3 deleted the desktop-popup-fix branch March 15, 2026 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant