feat: add support for custom patch delimiters in PatchDocumentOptions#3036
Merged
dolanmiu merged 2 commits intodolanmiu:masterfrom Apr 16, 2025
Merged
Conversation
Contributor
Author
|
Feature request: #2972 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3036 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 290 290
Lines 8764 8769 +5
Branches 1413 1421 +8
=========================================
+ Hits 8764 8769 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dolanmiu
approved these changes
Apr 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #2972
What does this PR do?
Adds support for customizable placeholder delimiters in the
patchDocumentfunction.This allows users to define delimiters other than
{{ }}, such as<< >>,{ }, or any custom format.Why is this needed?
Currently, the placeholder syntax is hardcoded to use
{{ }}. This enhancement enables more flexibility when using different template styles or avoiding syntax collisions.How does it work?
placeholderDelimitersfield toPatchDocumentOptions.{{and}}if none provided.patchTextis built.readonlyas per lint rules.Screenshots / Test Evidence
✅ Added tests for:
{{}}Checklist
npm run lintnpm run testLet me know if you'd like any changes!