Factor the TLM calculation out of Hessian calculation#212
Merged
JHopeCollins merged 5 commits intodham/abstract_reduced_functionalfrom Jul 23, 2025
Merged
Factor the TLM calculation out of Hessian calculation#212JHopeCollins merged 5 commits intodham/abstract_reduced_functionalfrom
JHopeCollins merged 5 commits intodham/abstract_reduced_functionalfrom
Conversation
dham
reviewed
Jul 1, 2025
Member
dham
left a comment
dham
left a comment
There was a problem hiding this comment.
Looks good to me, but will need tests (probably in Firedrake)
Member
I like this as well. I can add a test to https://github.com/jorgensd/dxa/blob/main/tests/test_poisson_mother.py#L90 as well, as I already compute the Tlm by hand there. |
Contributor
Author
Firedrake tests in firedrakeproject/firedrake#4448 |
dham
approved these changes
Jul 16, 2025
JHopeCollins
merged commit 2edf03b
into
dham/abstract_reduced_functional
1 check failed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently there is no way of asking pyadjoint to calculate the action of the TLM unless it's as part of the Hessian action.
This PR just make the TLM action a first class citizen like the adjoint and Hessian, with a driver and a
ReducedFunctionalmethod of its own.