This repository was archived by the owner on Jun 6, 2024. It is now read-only.
Open
Conversation
Author
|
I think we'd likely want to set the cloudworker/lib/runtime/fetch.js Line 78 in 93f853d |
hankjacobs
suggested changes
May 20, 2019
Contributor
hankjacobs
left a comment
hankjacobs
left a comment
There was a problem hiding this comment.
Looks good so far. Just one minor fix. Also, please merge in master. Thanks!
| if (httpsServer) { | ||
| httpsServer.close(() => { }) | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
It looks the return was dropped by this change. It's required so that a new server is created if stopping.
supermari0
force-pushed
the
tls-support-upstream
branch
from
e2edb35 to
b25003a
Compare
This adds support for processing HTTPS requests on a separate port from the usual HTTP requests. It does so by adding options for specifying the path to a TLS key and a TLS certificate. This can be useful for testing worker scripts that do things like custom redirects depending on whether the user is making an encrypted request or not. Note: This PR does not yet set special `request.cf` attributes such as `tlsVersion` and `tlsCipher` as described here: https://developers.cloudflare.com/workers/reference/request-attributes/
supermari0
force-pushed
the
tls-support-upstream
branch
from
b25003a to
a417b7b
Compare
Author
|
@hankjacobs I added back the |
|
Hi guys! Any plans on merging this PR? |
|
I would be interested in the functionality in this PR. Any plans on merging it? |
|
@hankjacobs Can we get this pulled in? We really need it. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for processing HTTPS requests on a separate port from
the usual HTTP requests. It does so by adding options for specifying the
path to a TLS key and a TLS certificate.
This can be useful for testing worker scripts that do things like custom
redirects depending on whether the user is making an encrypted request
or not.
Note: This PR does not yet set special
request.cfattributes such astlsVersionandtlsCipheras described here:https://developers.cloudflare.com/workers/reference/request-attributes/