StringUtil: Make UTF16ToUTF8 and UTF8ToUTF16 use custom encoding/decoding implementation. #14308
+194
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces: #14282.
Fixes: https://bugs.dolphin-emu.org/issues/13962
Note that
std::wstring_convertthrows exceptions on invalid sequences, and it's deprecated, to be removed in C++26.This PR replaces usage of
wstring_convertwith hand-rolled UTF8/16 encoding/decoding.I'd usually rather just use an existing libarary (like iconv) but..
MultiByteToWideCharcan't output to astd::u16stringwithout strict aliasing violations or a memcpy.If we wanted to entirely eliminate the iconv dependency, CP1252 would be easy enough to implement, but ShiftJIS looks like it isn't so fun.
Edit: I have these implemented locally if we want to do that. ShiftJIS wasn't so bad.. just some giant tables.