Update utils.py - replace/force-create import_mode were not being handled#32
Open
sidphbot wants to merge 1 commit intodolthub:mainfrom
Open
Update utils.py - replace/force-create import_mode were not being handled#32sidphbot wants to merge 1 commit intodolthub:mainfrom
sidphbot wants to merge 1 commit intodolthub:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #32 +/- ##
=======================================
Coverage 66.04% 66.04%
=======================================
Files 5 5
Lines 972 972
=======================================
Hits 642 642
Misses 330 330 Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
code snippet to reproduce:
doltcli
write_rows(write_rows(dolt, "characters", TEST_ROWS, REPLACE, ["id"])or via doltpy:
write_pandas(dolt, table_name, df, import_mode='replace')both call
_import_helperwhich refers todoltcli/doltcli/utils.py
Lines 251 to 265 in a807c93
the checks force it to return only
create/updatemode depending on existence of table,replace/force-createmodes are ignored