Skip to content

Add tests for ALTER COLUMN to assert that column default expressions are resolved #1294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2025
Merged

Add tests for ALTER COLUMN to assert that column default expressions are resolved #1294

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions testing/go/alter_table_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,6 +464,33 @@ func TestAlterTable(t *testing.T) {
},
},
},
{
Name: "ALTER COLUMN resolves column default expressions",
SetUpScript: []string{
"CREATE TABLE t1 (id VARCHAR PRIMARY KEY, c1 TIMESTAMP DEFAULT CURRENT_TIMESTAMP);",
"CREATE TABLE t2 (id VARCHAR PRIMARY KEY, c1 VARCHAR(100) DEFAULT concat('f', 'oo'));",
"CREATE TABLE t3 (id VARCHAR PRIMARY KEY, c1 VARCHAR(20) NOT NULL DEFAULT CONCAT('f', 'oo'));",
"CREATE TABLE t4 (id VARCHAR PRIMARY KEY, c1 VARCHAR(100) DEFAULT CONCAT('f', 'oo'));",
},
Assertions: []ScriptTestAssertion{
{
Query: "ALTER TABLE t1 ALTER COLUMN c1 SET NOT NULL;",
Expected: []sql.Row{},
},
{
Query: "ALTER TABLE t2 ALTER COLUMN c1 TYPE VARCHAR(50);",
Expected: []sql.Row{},
},
{
Query: "ALTER TABLE t3 ALTER COLUMN c1 DROP NOT NULL;",
Expected: []sql.Row{},
},
{
Query: "ALTER TABLE t4 RENAME COLUMN c1 TO ccc1;",
Expected: []sql.Row{},
},
},
},
{
Name: "Rename table",
SetUpScript: []string{
Expand Down
Loading