Skip to content

Conversation

@elianddb
Copy link
Contributor

@elianddb elianddb commented Aug 8, 2025

Add BIT type conversion support to doltgres query converter to enable compatibility with go-mysql-server UNION regression tests.
Companion dolthub/go-mysql-server#3148

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2025

Main PR
covering_index_scan_postgres 348.55/s 332.70/s -4.6%
index_join_postgres 154.95/s 156.83/s +1.2%
index_join_scan_postgres 187.47/s 189.90/s +1.2%
index_scan_postgres 12.48/s 12.57/s +0.7%
oltp_point_select 2469.72/s 2468.48/s -0.1%
oltp_read_only 1801.11/s 1806.15/s +0.2%
select_random_points 116.89/s 117.87/s +0.8%
select_random_ranges 126.68/s 127.23/s +0.4%
table_scan_postgres 11.86/s 11.66/s -1.7%
types_table_scan_postgres 5.48/s 5.46/s -0.4%

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2025

Main PR
Total 42090 42090
Successful 16724 16724
Failures 25366 25366
Partial Successes1 5545 5545
Main PR
Successful 39.7339% 39.7339%
Failures 60.2661% 60.2661%

Footnotes

  1. These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct.

@jennifersp
Copy link
Contributor

I think the PR title is misleading since it does not add BIT type support for doltgres. Maybe you can specify that it's mysql BIT type conversion support for enginetests. Also, maybe you can add [no-release-notes] tag in front of it. 🙂

@elianddb elianddb changed the title dolthub/dolt#9641 - Add BIT type support for UNION query compatibility dolthub/dolt#9641 - Add BIT type conversion support Aug 14, 2025
@elianddb elianddb changed the title dolthub/dolt#9641 - Add BIT type conversion support dolthub/dolt#9641 - Add BIT type conversion support [no-release-notes] Aug 14, 2025
@elianddb elianddb merged commit 892915d into main Aug 14, 2025
14 checks passed
@elianddb elianddb deleted the elianddb/9641-bit-type-support-for-union-queries branch August 14, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants