Skip to content

Conversation

@fulghum
Copy link
Contributor

@fulghum fulghum commented Dec 16, 2025

Adds a test for a bug in SHOW TABLES behavior that caused sequences to be included in returned results.

Depends on: dolthub/dolt#10220

Fixes: #1743

@github-actions
Copy link
Contributor

github-actions bot commented Dec 16, 2025

Main PR
covering_index_scan_postgres 570.81/s 571.56/s +0.1%
index_join_postgres 120.35/s 121.12/s +0.6%
index_join_scan_postgres 180.34/s 180.27/s -0.1%
index_scan_postgres 11.46/s 11.41/s -0.5%
oltp_point_select 2360.99/s 2323.53/s -1.6%
oltp_read_only 1706.54/s 1714.04/s +0.4%
select_random_points 108.47/s 107.78/s -0.7%
select_random_ranges 439.07/s 439.05/s -0.1%
table_scan_postgres 11.21/s 11.19/s -0.2%
types_table_scan_postgres 5.19/s 5.24/s +0.9%

@github-actions
Copy link
Contributor

github-actions bot commented Dec 16, 2025

Main PR
Total 42090 42090
Successful 17505 17505
Failures 24585 24585
Partial Successes1 5587 5587
Main PR
Successful 41.5895% 41.5895%
Failures 58.4105% 58.4105%

Footnotes

  1. These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct.

@fulghum fulghum requested a review from zachmu December 30, 2025 00:30
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fulghum fulghum merged commit 5c49b41 into main Jan 6, 2026
17 checks passed
@fulghum fulghum deleted the fulghum/bugfix branch January 6, 2026 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SHOW TABLES should not show sequences

3 participants