dolthub/dolt#10227: add dolt_status_ignored dolt system table #2196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add adapter and test expectations for the new dolt_status_ignored system table from PR dolthub/dolt#10227. This table provides the same information as dolt_status plus an additional ignored column indicating whether unstaged new tables match a pattern in dolt_ignore. Changes: - Add DoltgresDoltStatusIgnoredTableAdapter in status_ignored.go - Register DoltgresDoltStatusIgnoredTableAdapter in init.go - Update pgcatalog_test.go with new dolt_status_ignore table to expected tables - Add new dolt_status_ignore table to sequences_test.go expected tables Refs: dolthub/dolt#5862, dolthub/dolt#10227
Due to codeaucafe's contribution being on a fork updating the doltgresql's go.mod to point to the updates in the dolt PR, dolthub/dolt#10227 this requires a replace directive. This will at least allow us to ensure this DoltgreSQL's PR can run CI. Refs: dolthub/dolt#5862, dolthub/dolt#10227
Update pg_catalog test expectations to include new status_ignored system table in the dolt schema. Refs: dolthub/dolt#5862, dolthub/dolt#10227
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add adapter and test expectations for the new
dolt_status_ignoredsystem table from dolthub/dolt#10227.This table provides the same information as
dolt_statusplus an additionalignoredboolean column.Changes
DoltgresDoltStatusIgnoredTableAdapterinserver/tables/dtables/status_ignored.goserver/tables/dtables/init.gotesting/go/pgcatalog_test.gotesting/go/sequences_test.goDependencies