Skip to content

Fixed issues 2316 and 2318#2323

Merged
Hydrocharged merged 1 commit intomainfrom
daylon/more-issues-fixed
Feb 13, 2026
Merged

Fixed issues 2316 and 2318#2323
Hydrocharged merged 1 commit intomainfrom
daylon/more-issues-fixed

Conversation

@Hydrocharged
Copy link
Collaborator

This fixes:

For 2316, clients may only send a single format code that should apply to multiple values, but we assumed that their lengths always matched. This is fixed by extending the format code slice length to the same as the value slice if there is a single format code provided.

For 2318, it appears that Rust wants these values in binary format, so now we're returning them in binary format. I'm not sure why Rust doesn't accept text format like everything else does, but perhaps it's the default in Postgres so some ORMs only work with the default.

It's worth mentioning that tests for these exist only within the client tests, as I could not replicate the errors within our standard testing framework. As mentioned with the binary format, it seems that Rust isn't as permissive as other ORMs, so we have to test with Rust specifically.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 13, 2026

Main PR
covering_index_scan_postgres 559.36/s 550.33/s -1.7%
index_join_postgres 118.88/s 117.50/s -1.2%
index_join_scan_postgres 175.05/s 172.99/s -1.2%
index_scan_postgres 11.20/s 11.00/s -1.8%
oltp_point_select 2254.46/s 2237.68/s -0.8%
oltp_read_only 1670.59/s 1651.08/s -1.2%
select_random_points 107.02/s 105.10/s -1.8%
select_random_ranges 413.87/s 416.16/s +0.5%
table_scan_postgres 11.04/s 10.83/s -2.0%
types_table_scan_postgres 4.96/s 5.00/s +0.8%

@github-actions
Copy link
Contributor

github-actions bot commented Feb 13, 2026

Main PR
Total 42090 42090
Successful 17559 17559
Failures 24531 24531
Partial Successes1 5585 5585
Main PR
Successful 41.7177% 41.7177%
Failures 58.2823% 58.2823%

Footnotes

  1. These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct.

@Hydrocharged Hydrocharged force-pushed the daylon/more-issues-fixed branch from 4674cd2 to ca7b2e9 Compare February 13, 2026 11:15
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hydrocharged Hydrocharged merged commit a65f4ab into main Feb 13, 2026
17 checks passed
@Hydrocharged Hydrocharged deleted the daylon/more-issues-fixed branch February 13, 2026 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants