Skip to content

bugfix: support records containing non-DoltgresType values#2327

Open
fulghum wants to merge 1 commit intomainfrom
fulghum/record_type_fix
Open

bugfix: support records containing non-DoltgresType values#2327
fulghum wants to merge 1 commit intomainfrom
fulghum/record_type_fix

Conversation

@fulghum
Copy link
Contributor

@fulghum fulghum commented Feb 13, 2026

No description provided.

@github-actions
Copy link
Contributor

Main PR
covering_index_scan_postgres 567.17/s 555.28/s -2.1%
index_join_postgres 116.27/s 117.25/s +0.8%
index_join_scan_postgres 172.72/s 176.08/s +1.9%
index_scan_postgres 10.89/s 10.93/s +0.3%
oltp_point_select 2283.50/s 2213.68/s -3.1%
oltp_read_only 1667.86/s 1656.92/s -0.7%
select_random_points 103.99/s 104.95/s +0.9%
select_random_ranges 416.15/s 416.85/s +0.1%
table_scan_postgres 10.81/s 10.87/s +0.5%
types_table_scan_postgres 4.95/s 4.95/s 0.0%

@github-actions
Copy link
Contributor

Main PR
Total 42090 42090
Successful 17508 17559
Failures 24582 24531
Partial Successes1 5575 5585
Main PR
Successful 41.5966% 41.7177%
Failures 58.4034% 58.2823%

${\color{lightgreen}Progressions (52)}$

rowtypes

QUERY: create temp table quadtable(f1 int, q quad);
QUERY: create temp table people (fn fullname, bd date);
QUERY: create temp table pp (f1 text);
QUERY: insert into pp values (repeat('abcdefghijkl', 100000));
QUERY: select ROW(1,2) < ROW(1,3) as true;
QUERY: select ROW(1,2) < ROW(1,NULL) as null;
QUERY: select ROW(1,2,3) < ROW(1,3,NULL) as true;
QUERY: select ROW(11,'ABC') < ROW(11,'DEF') as true;
QUERY: select ROW(12,'ABC') > ROW(11,'DEF') as true;
QUERY: select ROW(1,2,3) < ROW(1,NULL,4) as null;
QUERY: select ROW(1,2,3) <> ROW(1,NULL,4) as true;
QUERY: select ROW(1,2) = ROW(1,2::int8);
QUERY: select ROW(1,2) in (ROW(3,4), ROW(1,2));
QUERY: select ROW(1,2) in (ROW(3,4), ROW(1,2::int8));
QUERY: select thousand, tenthous from tenk1
where (thousand, tenthous) >= (997, 5000)
order by thousand, tenthous;
QUERY: create temp table test_table (a text, b text);
QUERY: insert into test_table values ('a', 'b');
QUERY: insert into test_table select 'a', null from generate_series(1,1000);
QUERY: insert into test_table values ('b', 'a');
QUERY: create index on test_table (a,b);
QUERY: set enable_sort = off;
QUERY: select a,b from test_table where (a,b) > ('a','a') order by a,b;
QUERY: reset enable_sort;
QUERY: select ROW();
QUERY: select ROW() IS NULL;
QUERY: select array[ row(1,2), row(3,4), row(5,6) ];
QUERY: select row(1,1.1) = any (array[ row(7,7.7), row(1,1.1), row(0,0.0) ]);
QUERY: select row(1,1.1) = any (array[ row(7,7.7), row(1,1.0), row(0,0.0) ]);
QUERY: create type testtype1 as (a int, b int);
QUERY: create type testtype3 as (a int, b text);
QUERY: create type testtype5 as (a int);
QUERY: create type testtype2 as (a smallint, b bool);
QUERY: CREATE TABLE price (
    id SERIAL PRIMARY KEY,
    active BOOLEAN NOT NULL,
    price NUMERIC
);
QUERY: CREATE TYPE price_input AS (
    id INTEGER,
    price NUMERIC
);
QUERY: CREATE TYPE price_key AS (
    id INTEGER
);
QUERY: insert into price values (1,false,42), (10,false,100), (11,true,17.99);
QUERY: rollback;
QUERY: create temp table compos (f1 int, f2 text);
QUERY: select cast (fullname as text) from fullname;
QUERY: select fullname::text from fullname;

Footnotes

  1. These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant