-
-
Notifications
You must be signed in to change notification settings - Fork 39
create DoltgresType struct used for all types #904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hydrocharged
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of great work here! I've got quite a few comments, but most of them aren't too big. The core of the work looks great. Let me know once you've made them and I'll give it another look over!
Hydrocharged
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great job!
|
This reverts commit acfeca5.
Revert "Merge pull request #904 from dolthub/jennifer/type"
This PR replaces current
DoltgresTypeinterface withDoltgresTypestruct. All built-in types will have pre-defined values for this struct. User-defined types will populate the struct fields with appropriate values.Depends on dolthub/go-mysql-server#2736