Skip to content

0.55.5

Latest
Latest

Choose a tag to compare

View all tags
@github-actions github-actions released this 02 Mar 20:51
v0.55.5
30abcf8

Merged PRs

doltgresql

  • 2395: information schema sequences
    Adds sequences to information_schema, following the specification outlined by Postgresql here.
  • 2394: Implemented the binary wire format
    Fixes:
    • #2317
    • #2347
    • #2348
    • #2360
    • #2362
      In a nutshell, we did not respect a client's wishes when they requested that the results for some columns are returned in their binary format (obtained from their send function). Instead, we had hardcoded that some types, in certain circumstances, would only return their binary format, while others would strictly return their text format. This PR implements the binary wire format for every type that is currently supported. This also fixes numerous bugs that were hidden due to our incorrect behavior.
      In addition to the above fixes, this PR introduces a new test harness for analyzing our compatibility with the wire messages returned directly to Postgres clients. Thousands of lines of new tests have been added that ensure we're returning the exact correct results for a given set of messages (not just queries but the actual client messages), and the test harness allows for quick iteration when comparing what a Postgres server sends versus a Doltgres server, so we can ensure that we're returning the same bytes, not just the same overall structure.
  • 2187: #1648: fix VALUES clause type inference

    Summary

    VALUES clause type inference now uses PostgreSQL's common type resolution algorithm instead of using only the first row's type.
    existing issue: SELECT * FROM (VALUES(1),(2.01),(3)) v(n) failed with integer: unhandled type: decimal.Decimal

    Changes

    • Add ResolveValuesTypes analyzer rule that:
    • Collects types from all VALUES rows (not just the first)
    • Uses FindCommonType() to resolve per PostgreSQL's [UNION/CASE type resolution](https://www.postgresql.org/docs/15/typeconv-union-case.html; per FindCommonType doc comment)
    • Applies implicit casts to convert values to the common type
    • Updates GetField expressions in parent nodes (handles aggregates like SUM)
    • Add UnknownCoercion expression for unknown to target type coercion
    • add go and bats tests

    Questions for Reviewers

    1. Analyzer rule approach: Is adding this as an analyzer rule (after TypeSanitizer) the right approach? I considered alternatives but this seemed cleanest for handling the two-pass transformation needed for GetField updates. Open to feedback if there's a better pattern.
    2. PostgreSQL version: The code references PostgreSQL 15 docs. Should this stay as-is since doltgresql targets PG 15, or should it use /docs/current/?
      Fixes: #1648

Closed Issues

  • 2362: COUNT(*) returns wrong value via binary protocol (extended query)
  • 2360: Extended protocol sends JSONB as raw JSON text instead of binary JSONB format (missing 0x01 version prefix)
  • 2348: Extended protocol sends incorrect binary format for ENUM columns, causing client-side decode panic
  • 2347: Extended protocol sends empty binary payload for NUMERIC/DECIMAL columns, causing client panic
  • 2317: Extended protocol SELECT fails with 'permission denied for table pg_type'
  • 1648: the first value in VALUES should not determine the column type
Assets 9
Loading