update

Author: James Cor

memory/database.go

@@ -595,6 +595,13 @@ func (d *Database) GetViewDefinition(ctx *sql.Context, viewName string) (sql.Vie
 	return viewDef, ok, nil
 }
 
+// GetViewDefinitionAsOf implements the interface sql.ViewDatabase.
+func (d *Database) GetViewDefinitionAsOf(ctx *sql.Context, viewName string, asOf interface{}) (sql.ViewDefinition, bool, error) {
+	// TODO: gms in memory db doesn't actually support versioned views
+	viewDef, ok := d.views[strings.ToLower(viewName)]
+	return viewDef, ok, nil
+}
+
 type ReadOnlyDatabase struct {
 	*HistoryDatabase
 }

sql/mysql_db/privileged_database_provider.go

@@ -401,7 +401,7 @@ func (pdb PrivilegedDatabase) GetViewDefinitionAsOf(ctx *sql.Context, viewName s
 	if db, ok := pdb.db.(sql.VersionedViewDatabase); ok {
 		return db.GetViewDefinitionAsOf(ctx, viewName, asOf)
 	}
-	return sql.ViewDefinition{}, false, nil
+	return sql.ViewDefinition{}, false, sql.ErrAsOfNotSupported.New(pdb.db.Name())
 }
 
 // GetViewDefinition implements sql.ViewDatabase

sql/planbuilder/from.go

@@ -682,7 +682,6 @@ func (b *Builder) buildResolvedTable(inScope *scope, db, schema, name string, as
 		asOfLit = asof
 	}
 
-	// TODO: even if it's a view here; it might not have been before?
 	if view := b.resolveView(name, database, asOfLit); view != nil {
 		// TODO: Schema name
 		return resolvedViewScope(outScope, view, db, name)