Commit fd10f05
Address PR review feedback from jycor
- Use SqlMode struct instead of manual string parsing in isStrictMode
- Leverage LoadSqlMode() and ModeEnabled() methods for proper SQL mode detection
- Unskip enum default validation tests that now work with our implementation
- Update expected error types to ErrInvalidColumnDefaultValue for enum defaults
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <[email protected]>1 parent 13f103c commit fd10f05
2 files changed
+5
-12
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8465 | 8465 | | |
8466 | 8466 | | |
8467 | 8467 | | |
8468 | | - | |
8469 | 8468 | | |
8470 | | - | |
| 8469 | + | |
8471 | 8470 | | |
8472 | 8471 | | |
8473 | 8472 | | |
8474 | 8473 | | |
8475 | 8474 | | |
8476 | 8475 | | |
8477 | | - | |
8478 | 8476 | | |
8479 | | - | |
| 8477 | + | |
8480 | 8478 | | |
8481 | 8479 | | |
8482 | | - | |
8483 | 8480 | | |
8484 | | - | |
| 8481 | + | |
8485 | 8482 | | |
8486 | 8483 | | |
8487 | 8484 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
219 | 219 | | |
220 | 220 | | |
221 | 221 | | |
222 | | - | |
223 | | - | |
224 | | - | |
225 | | - | |
226 | | - | |
227 | | - | |
| 222 | + | |
| 223 | + | |
228 | 224 | | |
229 | 225 | | |
230 | 226 | | |
| |||
0 commit comments