[no-release-notes] tidy up analyzer rules #2686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-hoffman
reviewed
Oct 10, 2024
sql/analyzer/stored_procedures.go
Outdated
| } | ||
| // Blocks may have expressions declared directly on them, so we explicitly analyze the block node for variables | ||
| rulesToRun := []RuleId{resolveVariablesId} | ||
| var rulesToRun []RuleId |
Contributor
There was a problem hiding this comment.
is there more elimination we could do here?
max-hoffman
approved these changes
Oct 10, 2024
Contributor
max-hoffman
left a comment
max-hoffman
left a comment
There was a problem hiding this comment.
lgtm, thanks for the cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes unused rule ids and renames some ids/rules so naming convention is consistent