Planbuilder Authorization #2712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachmu
reviewed
Oct 23, 2024
Member
zachmu
left a comment
zachmu
left a comment
There was a problem hiding this comment.
An interface might make more sense than a function pointer. And you definitely need to be getting more info from the builder to avoid doing unnecessary work.
But this seems like a big improvement over putting auth on every node type.
Can we get rid of PrivilegedDatabase as well? That thing has always been a pain.
Hydrocharged
force-pushed
the
daylon/planbuilder-auth
branch
2 times, most recently
from
cbb9ee1 to
66dbf92
Compare
max-hoffman
reviewed
Oct 24, 2024
max-hoffman
reviewed
Oct 24, 2024
max-hoffman
reviewed
Oct 24, 2024
Contributor
max-hoffman
left a comment
max-hoffman
left a comment
There was a problem hiding this comment.
directionally lgtm, i agree w/ zach re: deleting the old interface and validation analyzer rules
Hydrocharged
force-pushed
the
daylon/planbuilder-auth
branch
from
66dbf92 to
22f2187
Compare
max-hoffman
approved these changes
Oct 30, 2024
Contributor
max-hoffman
left a comment
max-hoffman
left a comment
There was a problem hiding this comment.
Mostly much more elegant, just the two main comments about deleting code and then whether auth on catalog would solve some of your TODOs
Hydrocharged
force-pushed
the
daylon/planbuilder-auth
branch
4 times, most recently
from
ff77a2a to
0372991
Compare
Contributor
Author
Hydrocharged
force-pushed
the
daylon/planbuilder-auth
branch
from
0372991 to
263d9f2
Compare
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's missing:
information_schemadoesn't restrict it's output yetI think
SHOWandinformation_schemawill probably have the same solution, which may be to continue doing what we were doing before. Besides that, pretty much every works according to our current tests (outside of the aforementioned missing items).