remove plan.QueryProcess and move logic to finalizeIters
#2714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sql-server into james/queryprocess
jycor
changed the title
plan.QueryProcess and move logic to finalizeIters
max-hoffman
approved these changes
Oct 23, 2024
Contributor
max-hoffman
left a comment
max-hoffman
left a comment
There was a problem hiding this comment.
LGTM, the one meta thing to consider is if we can have finalizeIters not depend on plan nodes at some point
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the use of
plan.QueryProcessand part of thetrackProcessrule that adds/removes this node.Instead the
TrackedRowIteris created directly infinalizeIters.