-
-
Notifications
You must be signed in to change notification settings - Fork 238
implement EXPLAIN and EXPLAIN PLAN
#2784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
max-hoffman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, seems like it might be a bit disruptive
| ) | ||
|
|
||
| go 1.22.2 | ||
| go 1.23.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you wanna do this in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh wait, this is from vitess having a newer version of go...
|
|
||
| dummyRow := sql.Row{ | ||
| 1, // id | ||
| "SELECT", // select_type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe include a warning as long as the output isn't useful
Moving our current implementation of
EXPLAINtoEXPLAIN PLAN, and replaceEXPLAINwith a dummy implementation of MySQL'sEXPLAINLooks like this now:
related: dolthub/dolt#8592