apply table projections through Distinct nodes
#2796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-hoffman
approved these changes
Dec 18, 2024
Contributor
max-hoffman
left a comment
max-hoffman
left a comment
There was a problem hiding this comment.
LGTM, we have associated tests for the anti join change?
max-hoffman
reviewed
Dec 18, 2024
sql/analyzer/indexed_joins.go
Outdated
| if rt, ok := ta.Child.(*plan.ResolvedTable); ok { | ||
| if t := rt.UnderlyingTable(); t != nil { | ||
| if pt, ok := t.(sql.ProjectedTable); ok { | ||
| tmpTbl := pt.WithProjections(nil) |
Contributor
There was a problem hiding this comment.
sql.PrimaryKeyTable is how we do this in other places, i'm pretty sure the memo RelProps has this already
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't pruning table columns when there was a distinct clause over the projections, this resulted the deserialization of every column, even if they weren't going to make it to the result. This is bad for performance, especially if the unread columns are of
TEXT,LONGTEXT, 'BLOB,LONGBLOB` type as those are stored out of band, and take longer to deserialize.fixes: dolthub/dolt#8689