Skip to content

Bug fix: resolve column default expressions for ALTER COLUMN nodes #2895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2025
Merged

Bug fix: resolve column default expressions for ALTER COLUMN nodes #2895

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions sql/planbuilder/ddl.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1065,7 +1065,11 @@ func (b *Builder) buildAlterAutoIncrement(inScope *scope, ddl *ast.DDL, table *p
func (b *Builder) buildAlterNotNull(inScope *scope, ddl *ast.DDL, table *plan.ResolvedTable) (outScope *scope) {
outScope = inScope
spec := ddl.NotNullSpec
for _, c := range table.Schema() {

// Resolve the schema defaults, so we don't leave around any UnresolvedColumnDefault expressions,
// otherwise Doltgres won't be able to process these nodes.
resolvedSchema := b.resolveSchemaDefaults(inScope, table.Schema())
for _, c := range resolvedSchema {
if strings.EqualFold(c.Name, spec.Column.String()) {
colCopy := *c
switch strings.ToLower(spec.Action) {
Expand Down Expand Up @@ -1093,7 +1097,11 @@ func (b *Builder) buildAlterNotNull(inScope *scope, ddl *ast.DDL, table *plan.Re
func (b *Builder) buildAlterChangeColumnType(inScope *scope, ddl *ast.DDL, table *plan.ResolvedTable) (outScope *scope) {
outScope = inScope
spec := ddl.ColumnTypeSpec
for _, c := range table.Schema() {

// Resolve the schema defaults, so we don't leave around any UnresolvedColumnDefault expressions,
// otherwise Doltgres won't be able to process these nodes.
resolvedSchema := b.resolveSchemaDefaults(inScope, table.Schema())
for _, c := range resolvedSchema {
if strings.EqualFold(c.Name, spec.Column.String()) {
colCopy := *c
typ, err := types.ColumnTypeToType(&spec.Type)
Expand Down