fix NewServer call #2994
Merged
fix NewServer call #2994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for the contribution! |
Contributor
Author
|
I'm not sure how this could break a test :S |
this is a followup to dolthub#2989
srabraham
force-pushed
the
fix-newserver-readme
branch
from
09cde5c to
a1946bc
Compare
Contributor
Author
|
Hey @zachmu , could you please have another look at this? It previously flaked in CI. I've rebased it on main |
Contributor
Author
|
ping @zachmu |
Contributor
|
I'll make sure he looks at this today |
Member
|
Sorry for the delay, not sure why the test was breaking either. Any case, merged now. Thanks for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a followup to #2989